Changed how Kerberos authentication acquires subject to provide compatibility for Kerberos with Java 23 and above #2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyc
force-pushed
the
kerberos-subject-deprecation-fix
branch
from
6259d04
to
61e2a52
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2539 +/- ##
============================================
- Coverage 50.93% 50.92% -0.02%
- Complexity 3893 3898 +5
============================================
Files 147 147
Lines 33371 33384 +13
Branches 5593 5595 +2
============================================
+ Hits 16999 17001 +2
- Misses 13963 13976 +13
+ Partials 2409 2407 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Jeffery-Wasty
approved these changes
Nov 18, 2024
machavan
reviewed
Nov 19, 2024
lilgreenbird
approved these changes
Nov 19, 2024
lilgreenbird
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kerberos auth depends on calling
Subject.getSubject(), which is deprecated since JDK 17. Fall back to acquiring the subject through the replacement API when the deprecation exception is thrown.Codecov is a false negative. Existing tests do cover the scenario by being ran in different JDK versions.